Fix raw kubeconfig context switch #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlaverse
force-pushed
the
fix_kubeconfig_context_switch
branch
from
80b4081
to
e0ffc80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the handling of raw
kubeconfigfiles and the switch to a context.Since 1.8.0 the switch is done after settings the cluster up which doesn't make much sense and doesn't reflect what's in the documentation. Also and unrelated to this fix, this PR prefixes log lines with the name of the plugin, and add a warning if a user configures a context that does not exist in the
kubeconfigfile.Fixes #51