-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JENKINS-46253 Including support for subPath in configMaps Volumes #1024
Conversation
Can this be merged soon? We also need this functionality. |
I think this should also be expanded to the other volume types. |
Includes work from Miguel Campos (jenkinsci#1024) refs JENKINS-46253
Includes work from Miguel Campos (jenkinsci#1024) refs JENKINS-46253
Includes work from Miguel Campos (jenkinsci#1024) refs JENKINS-46253
Includes work from Miguel Campos (jenkinsci#1024) refs JENKINS-46253
Parameter subPath as @DataBoundSetter
src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateBuilder.java
Outdated
Show resolved
Hide resolved
@@ -8,6 +8,7 @@ | |||
/.idea/ | |||
*.iml | |||
nbactions.xml | |||
nb-configuration.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhhh why is unecesary? did not want to upload any file related to my IDE. that's why I included those lines into .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote "unrelated" because it's unrelated to the change you're making in this PR. Usually it is good practice to split this kind of changes into different PRs as it makes them easier to review and to audit later in case of regressions.
Tip: It's possible to configure a global .gitignore
for your user https://docs.github.com/en/get-started/getting-started-with-git/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I managed to resolve all the issues. can we leave the .gitignore to be included in this pr?
I really think having the NetBeans config in the git ignore is harmless and might help others.
having them in the global config file will make my life more complicated.
@@ -8,6 +8,7 @@ | |||
/.idea/ | |||
*.iml | |||
nbactions.xml | |||
nb-configuration.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote "unrelated" because it's unrelated to the change you're making in this PR. Usually it is good practice to split this kind of changes into different PRs as it makes them easier to review and to audit later in case of regressions.
Tip: It's possible to configure a global .gitignore
for your user https://docs.github.com/en/get-started/getting-started-with-git/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer
Thanks |
JENKINS-46253 Including support for subPath in configMaps Volumes
https://issues.jenkins.io/browse/JENKINS-46253?jql=text%20~%20subPath