Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-46253 Including support for subPath in configMaps Volumes #1024

Merged
merged 6 commits into from
Oct 5, 2021

Conversation

mcamposv
Copy link
Contributor

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
    JENKINS-46253 Including support for subPath in configMaps Volumes
  • Link to relevant issues in GitHub or Jira
    https://issues.jenkins.io/browse/JENKINS-46253?jql=text%20~%20subPath
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jglick jglick requested a review from Vlatombe August 19, 2021 12:21
@hameno
Copy link

hameno commented Sep 15, 2021

Can this be merged soon? We also need this functionality.

@hameno
Copy link

hameno commented Sep 15, 2021

I think this should also be expanded to the other volume types.

hameno pushed a commit to sprylab/kubernetes-plugin that referenced this pull request Sep 15, 2021
Includes work from Miguel Campos (jenkinsci#1024)

refs JENKINS-46253
hameno pushed a commit to sprylab/kubernetes-plugin that referenced this pull request Sep 15, 2021
Includes work from Miguel Campos (jenkinsci#1024)

refs JENKINS-46253
hameno pushed a commit to sprylab/kubernetes-plugin that referenced this pull request Sep 15, 2021
Includes work from Miguel Campos (jenkinsci#1024)

refs JENKINS-46253
hameno pushed a commit to sprylab/kubernetes-plugin that referenced this pull request Sep 15, 2021
Includes work from Miguel Campos (jenkinsci#1024)

refs JENKINS-46253
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@@ -8,6 +8,7 @@
/.idea/
*.iml
nbactions.xml
nb-configuration.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but ok.

Copy link
Contributor Author

@mcamposv mcamposv Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhhh why is unecesary? did not want to upload any file related to my IDE. that's why I included those lines into .gitignore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote "unrelated" because it's unrelated to the change you're making in this PR. Usually it is good practice to split this kind of changes into different PRs as it makes them easier to review and to audit later in case of regressions.

Tip: It's possible to configure a global .gitignore for your user https://docs.github.com/en/get-started/getting-started-with-git/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I managed to resolve all the issues. can we leave the .gitignore to be included in this pr?
I really think having the NetBeans config in the git ignore is harmless and might help others.
having them in the global config file will make my life more complicated.

pom.xml Outdated Show resolved Hide resolved
@@ -8,6 +8,7 @@
/.idea/
*.iml
nbactions.xml
nb-configuration.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote "unrelated" because it's unrelated to the change you're making in this PR. Usually it is good practice to split this kind of changes into different PRs as it makes them easier to review and to audit later in case of regressions.

Tip: It's possible to configure a global .gitignore for your user https://docs.github.com/en/get-started/getting-started-with-git/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer

@Vlatombe Vlatombe added the enhancement Improvements label Oct 5, 2021
@Vlatombe Vlatombe merged commit 730c66d into jenkinsci:master Oct 5, 2021
@mcamposv
Copy link
Contributor Author

mcamposv commented Oct 5, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements
Projects
None yet
3 participants