-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-70392] Kubernetes client 6.x follow-up compatibility #1289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks promising. What is missing in RJR to let this run in kind.sh
?
src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesFactoryAdapter.java
Show resolved
Hide resolved
package org.csanchez.jenkins.plugins.kubernetes.pipeline.steps; | ||
/** | ||
* Reusable steps for tests relying on RealJenkinsRule. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is backwards? (Javadoc first, then package
statement)
See #1290 for the follow-up (I needed to let this one go since the release was broken) |
I'm still getting this error with 3800.v54b_077b_94b_a_4
|
Getting the same error when trying to test connection from the Manage Nodes & Clouds > Kubernetes Cloud:
|
Same issue here with this plugin combination: Kubernetes Client API Plugin 6.3.1-206.v76d3b_6b_14db_b |
Same problem with this version of plugins |
Very sorry for these inconvenience, seems like I missed a few more occurrences. |
Thanks for taking care! |
For compatibility with Kubernetes client 6.x
Also adds RJR based tests as
JenkinsRule
tests did not catch the classloading issue.