Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use name instead of label for the nesting stack #137

Merged
merged 1 commit into from
Feb 23, 2017

Conversation

tobiash
Copy link

@tobiash tobiash commented Feb 23, 2017

I'm not entirely sure on this one, but since the inheritFrom field is supposed to contain a name, the nesting stack should also contain name instead of label.
I was not able to run all tests, but this fixes my problems with nesting podTemplate on my Jenkins instance.

@carlossg
Copy link
Contributor

what's the problem and how does it manifest?

@tobiash
Copy link
Author

tobiash commented Feb 23, 2017

Without this change, nesting podTemplate does not work at all for me in 0.11. It just uses the configuration from the innermost podTemplate. I think this is because #133 changed the code to lookup parent templates by name rather than by label.

@iocanel
Copy link
Contributor

iocanel commented Feb 23, 2017

@tobiash: you are right!

#133 was incomplete and your change is required.

@iocanel iocanel merged commit 2d57e19 into jenkinsci:master Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants