New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use name instead of label for the nesting stack #137

Merged
merged 1 commit into from Feb 23, 2017

Conversation

Projects
None yet
3 participants
@tobiash

tobiash commented Feb 23, 2017

I'm not entirely sure on this one, but since the inheritFrom field is supposed to contain a name, the nesting stack should also contain name instead of label.
I was not able to run all tests, but this fixes my problems with nesting podTemplate on my Jenkins instance.

@carlossg

This comment has been minimized.

Show comment
Hide comment
@carlossg

carlossg Feb 23, 2017

what's the problem and how does it manifest?

carlossg commented Feb 23, 2017

what's the problem and how does it manifest?

@tobiash

This comment has been minimized.

Show comment
Hide comment
@tobiash

tobiash Feb 23, 2017

Without this change, nesting podTemplate does not work at all for me in 0.11. It just uses the configuration from the innermost podTemplate. I think this is because #133 changed the code to lookup parent templates by name rather than by label.

tobiash commented Feb 23, 2017

Without this change, nesting podTemplate does not work at all for me in 0.11. It just uses the configuration from the innermost podTemplate. I think this is because #133 changed the code to lookup parent templates by name rather than by label.

@iocanel

This comment has been minimized.

Show comment
Hide comment
@iocanel

iocanel Feb 23, 2017

@tobiash: you are right!

#133 was incomplete and your change is required.

iocanel commented Feb 23, 2017

@tobiash: you are right!

#133 was incomplete and your change is required.

@iocanel iocanel merged commit 2d57e19 into jenkinsci:master Feb 23, 2017

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment