Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-72444] Add support for generic ephemeral storage #1489

Merged
merged 4 commits into from Jan 3, 2024
Merged

[JENKINS-72444] Add support for generic ephemeral storage #1489

merged 4 commits into from Jan 3, 2024

Conversation

idlefella
Copy link

@idlefella idlefella commented Dec 28, 2023 •
edited

Implemented support for generic ephemeral volumes: https://kubernetes.io/docs/concepts/storage/ephemeral-volumes/#generic-ephemeral-volumes

The PR adds the option "generic ephemeral volume" for volumes and workspace volumes. This has about the same behaviour as using a dynamic PVC, but uses the native kubernetes feature for that.

The code is unit tested and there are tests for CasC.

Resolves: https://issues.jenkins.io/browse/JENKINS-72444

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

Add support for generic ephemeral storage
f9b70af 
Signed-off-by: Marc Liechti <marc.liechti@trivo.ch>
@idlefella idlefella requested a review from a team as a code owner December 28, 2023 10:46
@idlefella
Copy link
Author

Hi, the tests didn't pass due to a network error:

Error response from daemon: Head "https://registry-1.docker.io/v2/library/busybox/manifests/latest": read tcp 10.200.2.11:58444->34.226.69.105:443: read: connection reset by peer

Can you please retry them?

@Vlatombe Vlatombe added the enhancement Improvements label Jan 3, 2024
@Vlatombe
* Refactor ephemeral volume logic, apply same defaults as DynamicPVC
ccfd496 
* Move up help files
* Remove erroneous subPath from DynamicPVCVolume
* Fix fields on creation
@Vlatombe
Mark DynamicPVC as deprecated
b5092f4
@Vlatombe Vlatombe merged commit 4230d0c into jenkinsci:master Jan 3, 2024
6 checks passed
@Vlatombe Vlatombe changed the title Add support for generic ephemeral storage [JENKINS-72444] Add support for generic ephemeral storage Jan 3, 2024
This was referenced Jan 17, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vlatombe Vlatombe Vlatombe approved these changes

Assignees
No one assigned
Labels
enhancement Improvements
Projects
None yet
Milestone
No milestone
2 participants
@idlefella @Vlatombe