New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce consistent versions for mock libraries #1519

Merged

Vlatombe merged 2 commits into jenkinsci:master from Vlatombe:enforcer-mockwebserver-same-version

Mar 8, 2024

Member

Vlatombe commented Mar 8, 2024 •

edited

Loading

We depend on mock libraries part of kubernetes-client or okhttp3, and these need to be kept in sync with the main library.

This adds enforcer executions that will fail the build if these start diverging.

Testing done

Submitter checklist

Beta Give feedback

Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure that the pull request title represents the desired changelog entry

Ensure that the pull request title represents the desired changelog entry
Options
Successfully updated the issue's project

There was an error updating the issue's project
Please describe what you did

Please describe what you did
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant issues in GitHub or Jira

Link to relevant issues in GitHub or Jira
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant pull requests, esp. upstream and downstream changes

Link to relevant pull requests, esp. upstream and downstream changes
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure you have provided tests - that demonstrates feature works or fixes the issue

Ensure you have provided tests - that demonstrates feature works or fixes the issue
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options


          Enforce mockwebserver to use a consistent version

f72a785

Vlatombe added the chore label

Vlatombe requested a review from a team as a code owner

March 8, 2024 09:06

Vlatombe enabled auto-merge (squash)

March 8, 2024 09:07

Vlatombe disabled auto-merge

March 8, 2024 09:08


          Also enforce kubernetes-server-mock

6cdb565

Vlatombe changed the title ~~Enforce mockwebserver to use a consistent version~~ Enforce consistent versions

Vlatombe changed the title ~~Enforce consistent versions~~ Enforce consistent versions for mock libraries

Vlatombe enabled auto-merge (squash)

March 8, 2024 09:12

Vlatombe merged commit e4b7ae9 into jenkinsci:master

5 of 6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment