[JENKINS-72886] fix command
& args
are lost when combining container templates
#1525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is described in detail here - https://issues.jenkins.io/browse/JENKINS-72886
This PR adds checks for empty Lists because
args
andcommand
fields are initialized as empty lists by default, and they can't benull
. Before this changeargs
andcommand
from parent template were overridden with empty values, becausenull
check always returnedfalse
.After this change
args
andcommand
fields will be preserved from parent template if child don't provide any. This is the expected behavior.Testing done
I've added simple unit test which failed before this change and now passes successfully. It check that fields from parent container template are present if child template doesn't contain these fields
Submitter checklist