Add command liveness probe support #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you could have force pushed to the same PR, now all the comments are lost in the other one #125 :( |
|
Sorry for the delay, I was on vacation. True, I should have done that. Should I still do it (push force and reopen the other PR) or will you simply keep the old one pointing here as a reference? Anyway I tried to follow all the comments that are in the old PR #(125). Is there anything else to fix? |
carlossg
reviewed
Jun 1, 2017
| @@ -39,6 +39,14 @@ | |||
| deleteCaption="Delete Environment Variable" /> | |||
| </f:entry> | |||
|
|
|||
| <f:entry field="livenessProbe" title="${%Liveness Probe}"> | |||
There was a problem hiding this comment.
liveness probe should be in the advanced section, at the end
it's also showing "Liveness Probe > Exec Action should not be empty"
There was a problem hiding this comment.
Ah, ok. I will fix this soon and submit a PR. Thanks for the good feedback :)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes will allow to add a command liveness probe to a container. You can specify:
command to execute (does not support httpGet) - required field
timeout seconds
initial delay seconds
failure threshold
period seconds
success threshold