New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command liveness probe support #158

Merged
merged 2 commits into from Jun 1, 2017

Conversation

Projects
None yet
2 participants
@lonefreak

lonefreak commented May 6, 2017

The changes will allow to add a command liveness probe to a container. You can specify:

command to execute (does not support httpGet) - required field
timeout seconds
initial delay seconds
failure threshold
period seconds
success threshold

@carlossg

This comment has been minimized.

Show comment
Hide comment
@carlossg

carlossg May 10, 2017

you could have force pushed to the same PR, now all the comments are lost in the other one #125 :(

carlossg commented May 10, 2017

you could have force pushed to the same PR, now all the comments are lost in the other one #125 :(

@carlossg carlossg closed this May 10, 2017

@carlossg carlossg reopened this May 10, 2017

@lonefreak

This comment has been minimized.

Show comment
Hide comment
@lonefreak

lonefreak May 13, 2017

Sorry for the delay, I was on vacation. True, I should have done that. Should I still do it (push force and reopen the other PR) or will you simply keep the old one pointing here as a reference?

Anyway I tried to follow all the comments that are in the old PR #(125). Is there anything else to fix?

lonefreak commented May 13, 2017

Sorry for the delay, I was on vacation. True, I should have done that. Should I still do it (push force and reopen the other PR) or will you simply keep the old one pointing here as a reference?

Anyway I tried to follow all the comments that are in the old PR #(125). Is there anything else to fix?

@carlossg carlossg merged commit da21731 into jenkinsci:master Jun 1, 2017

1 check was pending

Jenkins Jenkins is validating pull request ...
Details
@@ -39,6 +39,14 @@
deleteCaption="Delete Environment Variable" />
</f:entry>
<f:entry field="livenessProbe" title="${%Liveness Probe}">

This comment has been minimized.

@carlossg

carlossg Jun 1, 2017

liveness probe should be in the advanced section, at the end
it's also showing "Liveness Probe > Exec Action should not be empty"

@carlossg

carlossg Jun 1, 2017

liveness probe should be in the advanced section, at the end
it's also showing "Liveness Probe > Exec Action should not be empty"

This comment has been minimized.

@lonefreak

lonefreak Jun 2, 2017

Ah, ok. I will fix this soon and submit a PR. Thanks for the good feedback :)

@lonefreak

lonefreak Jun 2, 2017

Ah, ok. I will fix this soon and submit a PR. Thanks for the good feedback :)

@lonefreak lonefreak deleted the lonefreak:add-liveness-probe-support branch Jun 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment