New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step namespace should have priority over anything else. #161

Merged
merged 1 commit into from May 23, 2017

Conversation

Projects
None yet
2 participants
@iocanel

iocanel commented May 17, 2017

No description provided.

@@ -204,6 +204,28 @@ public void runWithOverriddenNamespace() throws Exception {
r.assertLogContains(overriddenNamespace, b);
}
@Test
public void runWithOverriddenNamespace2() throws Exception {

This comment has been minimized.

@carlossg

carlossg May 17, 2017

should this just be the only runWithOverriddenNamespace test ?
I'm not sure what the other one was testing because the namespace was not in the pipeline

@carlossg

carlossg May 17, 2017

should this just be the only runWithOverriddenNamespace test ?
I'm not sure what the other one was testing because the namespace was not in the pipeline

This comment has been minimized.

@iocanel

iocanel May 17, 2017

runWithOverriddenNamespace is meant to verify that if a namespace is not explicitly specified it will be picked up from the NamespaceAction.

runWithOverriddenNamespace2 is meant to verify that if a namepsace IS explictly specified its the one that will be used.

@iocanel

iocanel May 17, 2017

runWithOverriddenNamespace is meant to verify that if a namespace is not explicitly specified it will be picked up from the NamespaceAction.

runWithOverriddenNamespace2 is meant to verify that if a namepsace IS explictly specified its the one that will be used.

This comment has been minimized.

@iocanel
@iocanel

This comment has been minimized.

@iocanel

iocanel May 23, 2017

makes sense?

@iocanel

iocanel May 23, 2017

makes sense?

@carlossg carlossg merged commit 769bf1a into jenkinsci:master May 23, 2017

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment