Missing call to slave.terminate() #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently it is needed or jenkins will think failed nodes are still available in some cases
|
@reviewbybees |
carlossg
added a commit
that referenced
this pull request
Nov 29, 2017
Vlatombe
reviewed
Nov 29, 2017
| @@ -222,15 +222,16 @@ public void launch(SlaveComputer computer, TaskListener listener) { | |||
| if (containerStatuses != null) { | |||
| logLastLines(containerStatuses, podId, namespace, slave, null, client); | |||
| } | |||
| slave.terminate(); | |||
There was a problem hiding this comment.
Is this necessary? it's already called in the catch block
|
Do we want to test this in an installed cluster before merging it? |
|
The tests are run in my GKE cluster https://jenkins.gke.csanchez.org/blue/organizations/jenkins/jenkinsci%2Fkubernetes-plugin/detail/node-removal/1/ I'll go through some more testing before merging |
|
Technically oc-cloud is the best implementation... and Carlos should be able to see that, but there are some specifics to CJOC that may mean it is not as applicable to this plugin |
jaseemabid
added a commit
to fabric8io/openshift-jenkins-s2i-config
that referenced
this pull request
Mar 14, 2018
This might fix #17, slaves not reconnecting and pods not spawning up. I suspect jenkinsci/kubernetes-plugin#256 is the root cause and the fix is part of this release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently it is needed or jenkins will think failed nodes are still available in some cases,
not calling the plugin again to provision nodes,
thus leaving jobs stuck waiting for executor that will never be created
Based on yet-another-docker-plugin which was mentioned by @stephenc as a good example of cloud api implementation https://github.com/KostyaSha/yet-another-docker-plugin/blob/db0026ea46b1ca24a03c4212d09acefff0b1f2e4/yet-another-docker-plugin/src/main/java/com/github/kostyasha/yad/launcher/DockerComputerJNLPLauncher.java#L281