Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-50879] Add volumes from pod template to JNLP container #371

Merged
merged 2 commits into from Aug 28, 2018
Merged

[JENKINS-50879] Add volumes from pod template to JNLP container #371

merged 2 commits into from Aug 28, 2018

Conversation

mbarbero
Copy link
Contributor

Fix for JENKINS-50879. I re-activated the "PodTemplateBuilderTest.testBuildFromTemplate" test which was failing without this patch.

@carlossg carlossg merged commit 259617f into jenkinsci:master Aug 28, 2018
@carlossg
Copy link
Contributor

note that the preferred way is to use yaml and other podTemplate properties will be deprecated at some point

@carlossg
Copy link
Contributor

and thanks ! btw

@mbarbero
Copy link
Contributor Author

You're welcome. Thanks for the heads up about deprecation of podTemplate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mbarbero @carlossg