[JENKINS-58602] Hide JENKINS_SECRET from pod manifest

[Vlatombe]

JENKINS-58602

[jglick]

Some failures in KubernetesPipelineOverridenNamespaceTest [sic].

[Vlatombe]

Yes, currently looking into them, it looks like some flushing issue...

[jglick]

(once tests pass)

[Vlatombe]

@jglick I narrowed down the failures to something going wrong with the SecretsMasker. If I disable it as follow, the tests pass (but obviously some others would fail). I feel like this is a flushing issue but I can't pinpoint precisely where...

diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/SecretsMasker.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/SecretsMasker.java
index 127c002b..83d90608 100644
--- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/SecretsMasker.java
+++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/SecretsMasker.java
@@ -64,27 +64,7 @@ public final class SecretsMasker extends TaskListenerDecorator {
 
     @Override
     public OutputStream decorate(OutputStream logger) throws IOException, InterruptedException {
-        // TODO better to pick up a standard API from credentials-binding (more efficient)
-        // https://github.com/jenkinsci/credentials-binding-plugin/pull/59#discussion_r288735761
-        return new LineTransformationOutputStream() {
-            @Override
-            protected void eol(byte[] b, int len) throws IOException {
-                String s = new String(b, 0, len, StandardCharsets.UTF_8);
-                for (String value : values) {
-                    s = s.replace(value, "********");
-                }
-                logger.write(s.getBytes(StandardCharsets.UTF_8));
-            }
-            @Override
-            public void flush() throws IOException {
-                logger.flush();
-            }
-            @Override
-            public void close() throws IOException {
-                super.close();
-                logger.close();
-            }
-        };
+        return logger;
     }
 
     @Extension

[jglick]

See jenkinsci/workflow-durable-task-step-plugin#103. There are some sh steps printing text without a final newline. Try changing e.g.

cat /whatever

into

cat /whatever && echo

[Vlatombe]

Yep, looks like it does the trick.

[jglick]

I am digging into that bug by the way.