-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using GroovySample extension point #707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok though I feel uneasy with the writeFile
gym.
It is not great but the alternatives I could think of had worse problems:
At least the current approach is 100% self-contained. For purposes of PR review, it would be possible to load the external files from a classpath resource, but the sample script shown to a user would be the same. |
Downstream of jenkinsci/workflow-cps-plugin#350. Migrated those scripts in
examples/
which were self-contained (do not require manual preconfiguration, such as registry credentials or a PVC); were reasonably representative (covering some major use cases); and are compatible withPodSecurityPolicy
(so, no Docker).