Simplify caching by removing the close logic #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://square.github.io/okhttp/4.x/okhttp/okhttp3/-ok-http-client/#shutdown-isnt-necessary As the kubernetes client only close the underlying client, and it is not necessary to explicitly close http clients, it should be safe to leave as is once it is expired. If some calling code is holding to old instances, they can still use them provided the token-based authentication still works. Ultimately, this should prevent occurrences such as 2020-11-04 06:49:56.143+0000 [id=329776] WARNING i.f.k.c.d.i.WatchConnectionManager$1#onFailure: Exec Failure java.util.concurrent.RejectedExecutionException: Task okhttp3.RealCall$AsyncCall@556ba43e rejected from java.util.concurrent.ThreadPoolExecutor@217680e3[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 30] which denote some calling code trying to make a call using an http client instance which has been closed.
jglick
approved these changes
Nov 9, 2020
src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesClientProvider.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per
https://square.github.io/okhttp/4.x/okhttp/okhttp3/-ok-http-client/#shutdown-isnt-necessary
As the kubernetes client only close the underlying client, and it is not necessary to explicitly close http clients,
it should be safe to leave as is once it is expired.
If some calling code is holding to old instances, they can still use them provided the token-based authentication still works.
Ultimately, this should prevent occurrences such as
which denote some calling code trying to make a call using an http client instance which has been closed.