Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for variables in end revision input #5

Closed
rmpestano opened this issue Aug 10, 2017 · 7 comments
Closed

Support for variables in end revision input #5

rmpestano opened this issue Aug 10, 2017 · 7 comments

Comments

@rmpestano
Copy link
Contributor

We should be able to pass a variable to end revision input, currently the following error is throw:

ERROR: Last Changes NOT published due to the following error: For input string: "${REV}"
rmpestano added a commit that referenced this issue Aug 10, 2017
@rmpestano
Copy link
Contributor Author

rmpestano commented Aug 10, 2017

Hi @klavan,

can you test with the version below? you need to rename from .zip to .hpi and install into your Jenkins

last-changes.zip

@klavan
Copy link

klavan commented Aug 10, 2017

Hi @rmpestano,

Thanks for the response.
I still see the same error with the latest zip file you have provided.

Could you please help.

@rmpestano
Copy link
Contributor Author

Can you tell me how are you providing the variable? I've tested here with environment variables: https://stackoverflow.com/questions/30110876/passing-variable-from-shell-script-to-jenkins

@klavan
Copy link

klavan commented Aug 10, 2017

Thanks alot for the help @rmpestano.
I'm able to use the variable now through environment variable properties file.

Earlier i didn't store it in environment file and directly used it.
So i've faced the issue.

Its working now !!

@rmpestano
Copy link
Contributor Author

Great! I'll release a version with this fix today, thank you for the feedback 👍

@klavan
Copy link

klavan commented Aug 11, 2017

Hi @rmpestano,

I've found one more issue with providing environment variable in end_revision field.
It replaces environment variable after 1st run and it uses that constant value for further runs.

Can you please try this scenario ?

@rmpestano
Copy link
Contributor Author

Yes, thats a bug, I've created #6 to handle it. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants