Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaged golang version to 1.19.1 #60

Merged
merged 1 commit into from Oct 5, 2022

Conversation

ashmeer7
Copy link
Contributor

@ashmeer7 ashmeer7 commented Oct 4, 2022

This change updates the packaged golang version from 1.16 to 1.19.1. 1.16 has multiple known vulnerabilities which trips up vulnerability scanners. Updating to the latest golang version that is available at https://hub.docker.com/_/golang.

Once this is merged, I intend to upgrade the durable-task plugin with the new version.

Replaces #59

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@ashmeer7 ashmeer7 changed the title Upgrade the packaged golang version. Update packaged golang version to 1.19.1 Oct 4, 2022
@ashmeer7
Copy link
Contributor Author

ashmeer7 commented Oct 4, 2022

I currently don't know of a great way to add the test - If the plugin still builds, is that sufficient?

@ashmeer7
Copy link
Contributor Author

ashmeer7 commented Oct 4, 2022

Filed this ticket in case it helps: https://issues.jenkins.io/browse/JENKINS-69776

@car-roll
Copy link
Contributor

car-roll commented Oct 4, 2022

Hi @ashmeer7 thanks for the PR!
Yes, there are some tests that run in the docker build process you can see here: https://ci.jenkins.io/blue/rest/organizations/jenkins/pipelines/jenkinsci-libraries/pipelines/lib-durable-task/branches/PR-60/runs/1/nodes/33/log/?start=0

Once this is merged, I intend to upgrade the durable-task plugin with the new version.

We would actually need to test the incrementals generated here within the durable-task repo before merging this PR

@car-roll
Copy link
Contributor

car-roll commented Oct 4, 2022

jenkinsci/durable-task-plugin#154
closing PR as i realized this PR is incomplete

Copy link
Contributor

@car-roll car-roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would also need to bump golang in the windows versions as well
https://github.com/jenkinsci/lib-durable-task/blob/main/src/Dockerfile.windows

1.16 has multiple known vulnerabilities and at the very least trips up
vulnerability scanners
@ashmeer7
Copy link
Contributor Author

ashmeer7 commented Oct 4, 2022

Just did the update, ill have a follow up PR as soon as the incremental version builds.

@car-roll car-roll added the dependencies Pull requests that update a dependency file label Oct 4, 2022
ashmeer7 added a commit to ashmeer7/durable-task-plugin that referenced this pull request Oct 4, 2022
@ashmeer7
Copy link
Contributor Author

ashmeer7 commented Oct 4, 2022

Downstream test: jenkinsci/durable-task-plugin#155

@ashmeer7
Copy link
Contributor Author

ashmeer7 commented Oct 5, 2022

Looks like the tests passed. Is there anything else we need to look into?

Copy link
Contributor

@car-roll car-roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@car-roll car-roll merged commit 59c17a7 into jenkinsci:main Oct 5, 2022
@ashmeer7
Copy link
Contributor Author

ashmeer7 commented Oct 5, 2022

@car-roll - Does this need to be released? Or can I just send this version down?

@car-roll
Copy link
Contributor

car-roll commented Oct 5, 2022

@ashmeer7 it needs a release. I'm in the process of starting one.

@car-roll
Copy link
Contributor

car-roll commented Oct 5, 2022

@car-roll
Copy link
Contributor

car-roll commented Oct 5, 2022

@ashmeer7 actually, feel free to update jenkinsci/durable-task-plugin#155 with this version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants