Upgrade to Maven 3.8.1 and related dependency versions #38
Conversation
|
sounds good but does the plugin still work if using maven 3.6.3? |
|
Unlikely.
…On Wed, Jun 23, 2021, 04:06 Olivier Lamy ***@***.***> wrote:
sounds good but does the plugin still work if using maven 3.6.3?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RIE4AKZBZYAXMVF5K63TUE6R7ANCNFSM46NV6S3A>
.
|
|
@olamy @jenkinsci/core WDYT? I am +1 for merging and releasing |
| <version>4.2.1</version> | ||
| <classifier>no_aop</classifier> |
There was a problem hiding this comment.
As per https://github.com/jenkinsci/jenkins/blob/fdb52b3d04169e887777e4a98fdb1d4da6b30b67/bom/pom.xml#L96-L100 I think this dependency should be deleted altogether. https://www.jenkins.io/doc/developer/plugin-development/dependencies-and-class-loading/#pluginfirstclassloader-and-its-discontents
There was a problem hiding this comment.
(Changing to a version newer than in core is certainly incorrect.)
There was a problem hiding this comment.
Thanks for your time reviewing it. Just in case, the reason I updated this version is because Maven 3.8.1 depends on it. It doesn't necessarily mean it's a proper one in this case, just wanted to mention where it came from.
There was a problem hiding this comment.
Maven 3.8.1 depends on it
Or claims to. Regardless, unless you take special steps, code loaded inside the Jenkins controller or agent is going to used the 4.0 bundled in core.
There was a problem hiding this comment.
the 4.0 bundled in core
As of jenkinsci/jenkins#5858 this will be 5.x. The dependency should be deleted, and if necessary excluded from some other dependency.
Probably ought to have a RealJenkinsRule test verifying that this upgrade breaks nothing, and try on a recently weekly.
|
Push This issues blocks https://issues.jenkins.io/browse/JENKINS-59078 Would be very nice to use a Maven 3.6.1 feature before it's 3 years old. |
| <version>4.2.1</version> | ||
| <classifier>no_aop</classifier> |
There was a problem hiding this comment.
the 4.0 bundled in core
As of jenkinsci/jenkins#5858 this will be 5.x. The dependency should be deleted, and if necessary excluded from some other dependency.
Probably ought to have a RealJenkinsRule test verifying that this upgrade breaks nothing, and try on a recently weekly.
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
|
@jglick sorry, I am busy with other issues currently and won't have time working on this further. I'll let you or somebody else close it as incomplete or drive this home. Thanks. |
|
Push This issue still blocks https://issues.jenkins.io/browse/JENKINS-59078 |
|
Best to uninstall the very problematic and basically unmaintained |
This PR upgrades the Maven version to 3.8.1 and related dependency, such as the resolver and wagon, versions to the ones compatible with/included in the Maven 3.8.1 build.