Add possibility to configure colors #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuildWrapper has bugs with radio blocks (unchecked radio block show it's content anyway), can't be used.
Remove old step implementation in favor of LifxNotifier step
Saturation and brightness were hardcoded (1.0f) and this led to wrong colors as result. Hue value should be multiplied by 360.
|
@michaelneale If everything is fine, I merge this and prepare a release of the plugin. This is my first plugin release. I've read Hosting plugins wiki page, and in order to release a plugin I have to execute following command |
|
Changes Unknown when pulling 064a02e on vgaidarji:master into ** on jenkinsci:master**. |
|
@vgaidarji yes. I put my pwd in settings.xml as per instructions (encrypted) and it works fine. Worth a try. |
|
obviously you will need to merge this to master first before running mvn release:prepare release:perform |
|
@michaelneale ok, thanks. I wanted you to check the PR before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.