JENKINS-69771 Make listSize parameter optional

[JayZ-star]

Fixes issue JENKINS-69771

Release 0.0.11 included fix for listSize which made the listSize parameter now functional. However the way it was implemented also meant that listSize as a new parameter must be supplied and older parameter definition setup without a listSize parameter will cause the pipeline load to fail.

This change sets up parameter overloading for ListGitBranchesParameterDefinition so that if a listSize parameter is not supplied the default DEFAULT_LIST_SIZE of 5 is used instead, making the plugin backwards compatible with older pipeline parameter definition files made with 0.0.9 and earlier versions of the plugin.

Testing done

1. Replicating the issue:

Jenkins test instance, setup with listGitBranches 0.0.13

Issue described in JENKINS-69771 recreated

Issue is due to calling listGitBranches plugin with no listSize parameter, as this pipeline was defined with release 0.0.9 in mind.

2. Running test version:

Experimental hpi compiled from this branch deployed into test Jenkins instance

Running the same job again, the job is now successful in loading jobs from pipeline files.

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

   Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry

   Ensure that the pull request title represents the desired changelog entry
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Please describe what you did

   Please describe what you did
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Link to relevant issues in GitHub or Jira

   Link to relevant issues in GitHub or Jira
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Link to relevant pull requests, esp. upstream and downstream changes

   Link to relevant pull requests, esp. upstream and downstream changes
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

   Ensure you have provided tests - that demonstrates feature works or fixes the issue
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist

[JayZ-star]

@huangsuoyuan can you please review this PR?

[RobinFauvel]

Suggested change

	super(name, description);
	this.remoteURL = remoteURL;
	this.credentialsId = credentialsId;
	this.defaultValue = defaultValue;
	this.uuid = UUID.randomUUID();
	this.sortMode = sortMode;
	this.selectedValue = selectedValue;
	this.quickFilterEnabled = quickFilterEnabled;
	this.listSize = DEFAULT_LIST_SIZE;
	setType(type);
	setTagFilter(tagFilter);
	setBranchFilter(branchFilter);
	this(name, description, remoteURL, credentialsId, defaultValue, sortMode, selectedValue, quickFilterEnabled, type, tagFilter, branchFilter,
	DEFAULT_LIST_SIZE);