Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-possible-npe-in-get-queue #609

Merged

Conversation

mPokornyETM
Copy link
Contributor

fix #608

I can not really simulate this issues (and tries that few hours)
But when I try the steps described in #608 it works also with current release.

It might happens, that some other plugins or special settings like retention strategy,
will removed current job.
Anyway, I does not want to waste the time by finding exact scenario and just catch all exceptions as well.
That means, it does not matter, why we can not proceed the step, we will remove the item from queue and thats it.

Testing done

  • Added test case as describe in the issue
  • remove retry in test cases to make the tests more sensitive

Proposed upgrade guidelines

N/A

Localizations

N/A

Submitter checklist

  • The Jira / Github issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • The changelog generator for plugins uses the pull request title as the changelog entry.
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • There is automated testing or an explanation that explains why this change has no tests.
  • [ ] New public functions for internal use only are annotated with @NoExternalUse. In case it is used by non java code the Used by {@code <panel>.jelly} Javadocs are annotated.
  • [ ] New or substantially changed JavaScript is not defined inline and does not call eval to ease the future introduction of Content Security Policy (CSP) directives (see documentation).
  • [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • [ ] For new APIs and extension points, there is a link to at least one consumer.
  • [ ] Any localizations are transferred to *.properties files.
  • [ ] Changes in the interface are documented also as examples.

@mPokornyETM mPokornyETM added the Merged without review ! This PR was marged without reviewers label Jan 18, 2024
@mPokornyETM mPokornyETM merged commit 512d6c4 into jenkinsci:master Jan 18, 2024
16 checks passed
@mPokornyETM mPokornyETM deleted the fix-possible-npe-in-get-queue branch January 18, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug java Pull requests that update Java code Merged without review ! This PR was marged without reviewers parallelism and races ready for review PR is ready for review test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

it.getQueue() in /lockable-resources/. Reason: java.lang.NullPointerException
1 participant