New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move configuration to appearance page #37

Merged

jonesbusy merged 3 commits into jenkinsci:main from jonesbusy:feature/move-configuration-to-appearance-page

Sep 12, 2023

Contributor

jonesbusy commented Sep 12, 2023 •

edited

Requires:
jenkinsci/jenkins#8403

~~I would like to cut a release of this plugin before merging.~~

Same as jenkinsci/simple-theme-plugin#156

This add breaking change on the JCasC configuration

Testing done

mvn hpi:run to check the page
automated test for new JCasC configuration (was never implemented)

Submitter checklist

Beta Give feedback

Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure that the pull request title represents the desired changelog entry

Ensure that the pull request title represents the desired changelog entry
Options
Successfully updated the issue's project

There was an error updating the issue's project
Please describe what you did

Please describe what you did
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant issues in GitHub or Jira

Link to relevant issues in GitHub or Jira
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant pull requests, esp. upstream and downstream changes

Link to relevant pull requests, esp. upstream and downstream changes
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure you have provided tests - that demonstrates feature works or fixes the issue

Ensure you have provided tests - that demonstrates feature works or fixes the issue
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options


          Move configuration to appearance page

dd4e8fd

jonesbusy added enhancement breaking labels

jonesbusy requested a review from a team as a code owner

September 12, 2023 05:07

jonesbusy mentioned this pull request

Add Appearance system configuration page jenkinsci/jenkins#8403

Merged

jonesbusy marked this pull request as draft

September 12, 2023 05:14

jonesbusy marked this pull request as ready for review

September 12, 2023 05:17

timja reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved


          Fix bad copy paste

e8cf6c8

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>

timja approved these changes

View reviewed changes

Member

timja left a comment

Thanks!


          Set latest release 78 has compatible

df869ce

jonesbusy merged commit 6f8cc54 into jenkinsci:main

14 checks passed

jonesbusy deleted the feature/move-configuration-to-appearance-page branch

September 12, 2023 06:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment