Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of com.google.common.collect.Range and com.google.common.collect.Ranges #101

Merged
merged 1 commit into from Jul 9, 2021

Conversation

basil
Copy link
Member

@basil basil commented May 9, 2021

com.google.common.collect.Ranges was removed in Guava 15, so consuming this API is a liability. This PR replaces usages of com.google.common.collect.Range and com.google.common.collect.Ranges with native Java functionality to allow this plugin to be used seamlessly with any version of Guava in the future.

@basil
Copy link
Member Author

basil commented Jul 5, 2021

@jakub-bochenski Would you be able to take a look at this PR?

@jakub-bochenski
Copy link

@basil please accept my apologies, I must've missed the notification earlier

@jakub-bochenski
Copy link

@basil
Copy link
Member Author

basil commented Jul 9, 2021

Jenkins core still uses Guava 11. And Ranges (not Range) has been removed in Guava 15. You are using a method that is preventing Jenkins core from upgrading Guava from 11 to latest. This PR fixes that by making your plugin compatible with both versions of Guava.

@jakub-bochenski jakub-bochenski merged commit 7ee859a into jenkinsci:master Jul 9, 2021
@basil basil deleted the range branch July 9, 2021 16:18
@basil
Copy link
Member Author

basil commented Jul 13, 2021

Thanks for merging this! Could a new release of the plugin be made that includes this fix? This will allow users to upgrade ahead of time, giving Jenkins core the flexibility to upgrade Guava without affecting users of this plugin who have upgraded.

@basil basil mentioned this pull request Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants