Upgrade Mockito to Java 21 compatible version #80
Conversation
pom.xml
Outdated
| <configuration> | ||
| <!-- TODO fails on CI on Windows for inscrutable reasons --> | ||
| <excludes> | ||
| <exclude>org.jenkinsci.plugins.mailwatcher.NodeStatusTest</exclude> |
There was a problem hiding this comment.
Prefer adding junit assumption testing the platform to the test itself. It is a oneliner...
There was a problem hiding this comment.
As a courtesy, I have accommodated your preference in commit 0815db8.
In the future, I would prefer to understand the reasoning behind requests that are made of me in code reviews.
There was a problem hiding this comment.
Fair enough. I find this beneficial as the fact the test is platform dependent is in the eyes of the test developer - colocated with the platform dependent code. When stated in the pom file only, it can let one wander how the code they are looking at is supposed to run on platform X.
|
@olivergondza Gentle ping. Would be good to get this merged/released to facilitate Java 21 platform support |
|
Thanks for the fix, @basil. |
Reduces usages of PowerMock to just the
powermock-reflectlibrary, allowing us to upgrade Mockito to the latest version and also to upgrade to the latest parent POM, which in turn unblocks Java 21 support. While I was here I also sorted the dependencies for legibility.