Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72240] Add top level license declarations #50

Merged
merged 1 commit into from Nov 19, 2023

Conversation

MarkEWaite
Copy link
Contributor

[JENKINS-72240] Add top level license declarations

JENKINS-72240 notes that the plugin does not declare the license in its pom.xml or in a LICENSE file. Many of the source files include an MIT license header. No other license is visible in the source files, except MIT license, so it seems safe to declare the plugin as using the MIT license.

Dates in the copyright notice were extracted from the git commits and the license headings added to source files.

Testing done

Reviewed git history of the license headings that exist in the files to confirm their date ranges.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes

https://issues.jenkins.io/browse/JENKINS-72240 notes that the plugin
does not declare the license in its pom.xml or in a LICENSE file. Many
of the source files include an MIT license header.  No other license
is visible in the source files, except MIT license, so it seems safe to
declare the plugin as using the MIT license.

Dates in the copyright notice were extracted from the git commits and
the license headings added to source files.
@MarkEWaite MarkEWaite requested a review from a team as a code owner October 28, 2023 22:00
@MarkEWaite
Copy link
Contributor Author

@ikedam or @omer727 would you be willing to review and merge this pull request to resolve JENKINS-72240?

Copy link
Member

@ikedam ikedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I believe matrix-combinations-parameter is under the MIT license.

@ikedam ikedam merged commit adc5347 into jenkinsci:master Nov 19, 2023
16 checks passed
@MarkEWaite MarkEWaite deleted the declare-license branch November 19, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants