[JENKINS-26582] Ignore attempts to schedule a MatrixConfiguration directly #19
Conversation
| } | ||
| } | ||
|
|
||
| if (a == null) { | ||
| LOGGER.log(Level.WARNING, "JENKINS-26582: ignoring apparent attempt to trigger {0} without its parent", getFullName()); |
There was a problem hiding this comment.
I think Jenkins log is no a right place for JENKINS issue references. A comment would be better
There was a problem hiding this comment.
There are various precedents for this. It is useful to have the issue noted in the Jenkins log, so that if you are trying to diagnose a warning you can immediately get the proper context.
There was a problem hiding this comment.
@jglick Would a stack trace be helpful here, to see how this got scheduled?
There was a problem hiding this comment.
I think a stack trace would only indicate when this went to an executor, not when it was scheduled to the queue, but I could be wrong. If you rerun the test case for this bug with a Thread.dumpStack() here and it shows the buggy part of git-plugin then by all means add a stack trace.
There was a problem hiding this comment.
@jglick I think you're right, those stack traces start in the executor, so wouldn't help.
|
@jglick |
Debatable. |
…ell go to the LTS baseline 1.609.
|
@oleg-nenashev etc.? |
|
👍 insofar as I get it (can't see anything obviously wrong anyway) |
|
👍 |
[JENKINS-26582] Ignore attempts to schedule a MatrixConfiguration directly
JENKINS-26582
@reviewbybees