JENKINS-43446 - java.lang.NoSuchFieldError: DEFAULT_USER_SETTINGS_FILE

[tomerc]

Introduce an interceptor for Maven 3.5.0 and above which uses the DEFAULT_USER_SETTINGS_FILE from its new location at "org.apache.maven.cli.configuration.SettingsXmlConfigurationProcessor"

[oleg-nenashev]

Would be nice to have a description for such long pull request

[tomerc]

Updated comment

[aheritier]

close/reopen to re-trigger the build which was killed by the timeout (> 300% than the previous build which took 47s)

[aheritier]

LGTM @oleg-nenashev cc @olamy

[aheritier]

But one day ... we'll have to refactor the code to avoid all the copy/paste :(

[olamy]

lgtm.
Well I agree some refactor is needed to avoid all the copy/paste.

[oleg-nenashev]

semi-blind 👍 since I do not see newly introduced issues

[tomerc]

Please hold off 1 day before merging, I found a bug that needs to be addressed before it's merged

[tomerc]

I added the following:

1. If in batch mode, disable the ANSI coloring (shows up as gibberish on the Jenkins console)
2. If the maven.conf system.property does not exist, revert to maven 3.3 logic:
   new File(System.getProperty("maven.home", System.getProperty("user.dir", "")), "conf").getCanonicalPath()
3. the main method in the launcher now requires ClassWorld as its second paramter

[aheritier]

@tomerc take your time, I'll do more intensive tests before merging
About colors output I was thinking to propose to add the AnsiColor plugin as a dep of the maven-plugin and automatically configure it if Maven >= 3.5
It shouldn't be so hard. WDYT ?

[tomerc]

@aheritier Thanks! I think if we can make use of the AnsiColor plugin that would be great. Right now the -B option is always passed to the embedder and if I remember what Hevre wrote in the mailing list, if you execute Maven via the CLI with -B it would turn off the colors, so this would make it consistent, but perhaps we can override that for Maven 3.5?

[aheritier]

Yes confirm, -B deactivates the color like said @hboutemy But yes we can probably hack it :-)

[dreis2211]

Hi @aheritier . Any news on the progress?