Share #7
Share #7
Conversation
This the first step towards using the share extension to reduce disk usage. In that scenario multiple jobs will share and update the same mercurial data store, i.e. the same history DAG, so 'hg incoming' loses its meaning. TODO : see how compatible this is with the forest extension
…ing option TODO: transition between caching and sharing
|
I've just found an issue with this pull request : it uses 'hg tip' to determine the current state of the repository, which is wrong. The tip in Mercurial is the changeset that was added last to the history, no matter what branch, so it's basically nearly always useless. You want to use 'hg parent' to get the revision to which you just updated EDIT : never mind, hg.tip() does not use 'hg tip', but 'hg log --rev .', which is correct |
…he previous build, rather than the changes since the latest build on this slave, which can be quite different.
…on may not be renamed to installationName
|
I'm working on testing this pull request. Assuming that I don't find any problems, I'll commit it. |
| @@ -67,6 +65,22 @@ public class MercurialChangeLogParser extends ChangeLogParser { | |||
| } | |||
| } | |||
|
|
|||
| //sort the changes from oldest to newest, this gives the best result in the Jenkins changes view, | |||
There was a problem hiding this comment.
Why was this part needed? Did the rev specification in determineChanges not give the right ordering, or was this to handle backwards compatibility with previous versions of the plugin that may have persisted change log files with incorrect ordering?
|
Have yet to understand the purpose of this feature. If you simply use caching, then the repo in a workspace will already be hard-linked to the (local) cache repo, so all "similar" repos on a given node should be sharing data store files at the inode level even without the Share extension. (Assuming your Mercurial is new enough to have the Relink extension, this should also be true after repeated updates: the workspace repos are periodically relinked against the cache.) |
Added support for the Mercurial's ShareExtension to reduce disk usage.
To get there, I switched polling and changelog calculation to a 'hg log' based technique, added an extra share checkbox in the installation configuration and updated the MercurialSCM implementation.
The changes are covered by tests.
There are still some serious opportunities for refactoring.
-The pull request for [JENKINS-10255] has not been incorporated into this yet. Since the polling and changelog calculation in this pull request is already based on hg log iso hg incoming, it should be possible to incorporate a fix for [JENKINS-10255] in this pull request.-
EDIT : JENKINS-10255 has been fixed in the meantime