[JENKINS-64105] Add optional SSHAuthenticator implementation

[Dohbedoh]

(move jenkinsci/ssh-credentials-plugin#126 here with ssh-credentials as an optional dependency)

JENKINS-64105: Added MinaSSHPasswordKeyAuthenticator and MinaSSHPublicKeyKeyAuthenticator to provide authentication support with an Apache Mina SSHD ClientSession.

See also:

• https://javadoc.io/static/org.apache.sshd/sshd-core/2.8.0/org/apache/sshd/client/session/ClientSession.html
• https://mina.apache.org/mina-project/userguide/ch4-session/ch4-session.html
• https://github.com/apache/mina-sshd/blob/master/docs/client-setup.md

Note: also added system property to control the auth timeout when doing the auth (those defaults to 15s which I believe is more than reasonable):

• io.jenkins.plugins.mina_sshd_api.core.authenticators.MinaSSHPasswordKeyAuthenticator.authTimeout
• io.jenkins.plugins.mina_sshd_api.core.authenticators.MinaSSHPublicKeyAuthenticator.authTimeout

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[Dohbedoh]

While testing integration within on a Jenkins instance, I noticed that snakeyaml-api plugin causes a dependency cycle (due to an implied dependency on sshd):

2022-06-30 02:10:17.461+0000 [id=28]	SEVERE	hudson.PluginManager$1$3$2$1#reactOnCycle: found cycle in plugin dependencies: (root=Plugin:snakeyaml-api, deactivating all involved) Plugin:snakeyaml-api -> Plugin:sshd -> Plugin:mina-sshd-api-core -> Plugin:ssh-credentials -> Plugin:credentials -> Plugin:configuration-as-code -> Plugin:snakeyaml-api

Would need to bump jenkins version requirement of snakeyaml-api apparently. I did exactly that and that fixed it.
Not sure if other dependent plugin might be impacted..

[jetersen]

new version of BOM is available with fixed snakeyaml: https://github.com/jenkinsci/bom/releases/tag/1466.v85a_616ea_b_87c

[jetersen]

Should be able to merge/rebase and all should be good 😄

[fautpasycraindre]

hello @Dohbedoh . It seems to be an issue with SSHD from the new release. I had to rollback manually .jpi file to get Jenkins running again (it blocks all plugins). Could you have a look please ?

Edit: files to rollback (use .bak in plugins folder)

• mina-sshd-api-core.jpi
• mina-sshd-api-common.jpi

[TomHellier]

@Dohbedoh

can confirm, we're seeing the same issue.

Will try rolling back jpi file, thanks @fautpasycraindre

[Dohbedoh]

I did not test this with CasC or a dependent of commons-lang3-api-plugin installed. Sorry for the inconvenience.
But that seems to be a problem in jenkinsci/commons-lang3-api-plugin#18 actually. Will take a look in a bit.

[Dohbedoh]

Should be fixed by jenkinsci/commons-lang3-api-plugin#19