NaginatorPublisher: Renamed isCheckRegexp to getCheckRegexp.

[mjainta]

I've found a problem since version 1.16

Since 1.16 the regex-Check does not work in combination with checking Matrix-Child-Builds.

As seen in https://wiki.jenkins-ci.org/display/JENKINS/Basic+guide+to+Jelly+usage+in+Jenkins we either need a public checkRegexp field or a getCheckRegexp() function in the NaginatorPublisher class to correctly pass the parameter from the config.jelly

I've provided a fix for that, tho I skipped the tests run using maven in this step. I would appreciate if you could turn this into the next version of the plugin to fix this problem.

[ikedam]

Would you tell me more details about the problem? (e.g. how to reproduce the problem and what happens)
As far as I know, regexp for matrix children is introduced since 1.16.
I cannot get what do you mean with "does not work since 1.16".

[jenkinsadmin]

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

[mjainta]

Sure, sorry for that short description, gonna try to clear that out.

1. Create a Matrix-Configuration-Project
   • With a Shell-Task "exit 1"
   • With retry enabled on child-builds and a regex check "thatcannotbe"
2. Trigger this job
3. The job will be retriggered, although the regex-check "thatcannotbe" cannot be true

Cause of the Problem: The option checkRegexp will not be passed to the NaginatorPublisher.

Jenkins needs a public checkRegexp field or a getCheckRegexp() function in the class to do that, as we can read here since we use @DataBoundConstructor for the config passing.

[ikedam]

Thanks for the details.
The problem doesn't relate to @DataBoundConstructor.
checkRegexp is saved as expected.
I don't think this change fixes the problem.

The problem caused as following ways:

• "Regular expression to search for" is applied for matrix children only when "Rerun build only for failed parts on the matrix" is checked.
• When no children matches the regexp, naginator triggers whole the matrix. This looks like naginator ignores the regexp.

I'll file this issue in JIRA.

Would you see followings?

• Does this change actually fix your problem? (testing locally)
• What happens when you check "Rerun build only for failed parts on the matrix" and regexp matches only one combination?
  • Regexp like "workspace/axis1/value1"

[ikedam]

Created.
JENKINS-32821 Regexp doesn't work for matrix-children if without rerunMatrixPart
JENKINS-32823 Whole matrix is triggered when no chilren matched regexp.

[mjainta]

Thank you for opening the Bug, appreciate it.

Would you see followings?

Does this change actually fix your problem? (testing locally)
What happens when you check "Rerun build only for failed parts on the matrix" and regexp matches only one combination?
Regexp like "workspace/axis1/value1"

I´m today not able to check it again in our system, but:

• This change actually fixed the problem, so far I can tell
• Today I dont have a system to try that out today but in my memory "Rerun build only for failed parts on the matrix" works as expected to be

To be honest, the fact that the regexp check is only active on "Rerun build only for failed parts on the matrix" wasnt clear to me from the beginning, so maybe some other fix would fit more. Still my fix works for our situation (letting all child-builds retry when atleast one of them matches the regex)

[mjainta]

I just checked it on our system, my change truly didnt fix anything :(
I appreciate that you created the JIRA tickets for this. You can close the pull request if you want to.

What happens when you check "Rerun build only for failed parts on the matrix" and regexp matches only one combination?

Still I tried this one, it correctly reruns only the one axis. In the case the regexp does not match a single axis, all axis get rerun.

[ikedam]

Thanks for checking.
Do you have a JIRA account?
I want you watch tickets and review my following fixes if you don't mind.

[mjainta]

Hey there,

unfortunately I don´t have a JIRA account.
I wouldn´t mind watching tickets and reviewing fixes, if I would be able to get an account, tho.

[ikedam]

OK, I'll mention you when creating pull requests for them.

[mjainta]

Thank you!