Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2.6 regression on group field and deprecate Jackson parser (fix #236) #280

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

michael-doubez
Copy link
Contributor

@michael-doubez michael-doubez commented Mar 20, 2024

In 2.6, introduction of group field splitting caused a regression when loading config from XML (see #236).

At the same time, deprecating usage of Jackson2 for using GSon everywhere since it is used by google api.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@michael-doubez michael-doubez self-assigned this Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 71.90%. Comparing base (22331f0) to head (657a4f5).
Report is 3 commits behind head on master.

Files Patch % Lines
...va/org/jenkinsci/plugins/oic/OicSecurityRealm.java 52.94% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #280      +/-   ##
============================================
- Coverage     71.90%   71.90%   -0.01%     
- Complexity      194      196       +2     
============================================
  Files             9        9              
  Lines           744      751       +7     
  Branches        124      126       +2     
============================================
+ Hits            535      540       +5     
- Misses          150      151       +1     
- Partials         59       60       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-doubez michael-doubez merged commit 62720cf into jenkinsci:master Mar 20, 2024
17 of 18 checks passed
@michael-doubez michael-doubez deleted the groups-regression branch March 20, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant