Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code cleaning #289

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Conversation

michael-doubez
Copy link
Contributor

Clean pom and update checkstyle

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@michael-doubez michael-doubez self-assigned this Apr 3, 2024
@michael-doubez michael-doubez added skip-changelog dependencies Pull requests that update a dependency file labels Apr 3, 2024
@michael-doubez michael-doubez changed the title Update checkstyle Improve automation Apr 4, 2024
@michael-doubez michael-doubez changed the title Improve automation Improve code cleaning Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 58.26772% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 73.16%. Comparing base (22331f0) to head (c3d9244).
Report is 9 commits behind head on master.

Files Patch % Lines
...va/org/jenkinsci/plugins/oic/OicSecurityRealm.java 53.06% 34 Missing and 12 partials ⚠️
...ain/java/org/jenkinsci/plugins/oic/OicSession.java 57.14% 2 Missing and 1 partial ⚠️
...gins/oic/WellKnownOpenIDConfigurationResponse.java 60.00% 2 Missing ⚠️
...sci/plugins/oic/JenkinsAwareConnectionFactory.java 0.00% 0 Missing and 1 partial ⚠️
...va/org/jenkinsci/plugins/oic/OicTokenResponse.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #289      +/-   ##
============================================
+ Coverage     71.90%   73.16%   +1.25%     
+ Complexity      194      189       -5     
============================================
  Files             9        9              
  Lines           744      775      +31     
  Branches        124      113      -11     
============================================
+ Hits            535      567      +32     
- Misses          150      151       +1     
+ Partials         59       57       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-doubez michael-doubez merged commit 94cdf03 into jenkinsci:master Apr 4, 2024
17 of 18 checks passed
@michael-doubez michael-doubez deleted the checkstyle branch April 4, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant