Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JWKS parameters for verifying web token signatures #297

Merged

Conversation

michael-doubez
Copy link
Contributor

@michael-doubez michael-doubez commented Apr 11, 2024

Activate verification of token signature. Fix #89

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 67.24138% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 73.27%. Comparing base (c3d9244) to head (9442607).
Report is 12 commits behind head on master.

Files Patch % Lines
...va/org/jenkinsci/plugins/oic/OicSecurityRealm.java 57.89% 10 Missing and 6 partials ⚠️
...jenkinsci/plugins/oic/OicJsonWebTokenVerifier.java 85.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #297      +/-   ##
============================================
+ Coverage     73.16%   73.27%   +0.11%     
- Complexity      189      209      +20     
============================================
  Files             9       10       +1     
  Lines           775      872      +97     
  Branches        113      123      +10     
============================================
+ Hits            567      639      +72     
- Misses          151      170      +19     
- Partials         57       63       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-doubez michael-doubez self-assigned this Apr 12, 2024
@michael-doubez michael-doubez added enhancement draft Work in progress labels Apr 12, 2024
@michael-doubez michael-doubez requested a review from a team as a code owner April 14, 2024 21:11
@michael-doubez michael-doubez removed the draft Work in progress label Apr 20, 2024
@michael-doubez michael-doubez merged commit 5ad9932 into jenkinsci:master Apr 20, 2024
17 of 18 checks passed
@michael-doubez michael-doubez deleted the jws-signing-verification branch April 20, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest OIDC plugin does not support digital signing of userinfo
1 participant