Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable JWKS verification if not supported by client library #308

Merged
merged 2 commits into from
May 1, 2024

Conversation

michael-doubez
Copy link
Contributor

OAuth backend is based on Google specs and some JWKS features are not supported. In this case, a warning is issued and signature verification is disabled.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@michael-doubez michael-doubez requested a review from a team as a code owner May 1, 2024 12:54
@michael-doubez michael-doubez self-assigned this May 1, 2024
@michael-doubez michael-doubez linked an issue May 1, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 73.35%. Comparing base (9442607) to head (e327bf2).
Report is 4 commits behind head on master.

Files Patch % Lines
...jenkinsci/plugins/oic/OicJsonWebTokenVerifier.java 85.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #308      +/-   ##
============================================
+ Coverage     73.27%   73.35%   +0.07%     
- Complexity      209      211       +2     
============================================
  Files            10       10              
  Lines           872      882      +10     
  Branches        123      124       +1     
============================================
+ Hits            639      647       +8     
- Misses          170      172       +2     
  Partials         63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-doubez michael-doubez merged commit 5360e84 into jenkinsci:master May 1, 2024
18 checks passed
@michael-doubez michael-doubez deleted the robust-jwks branch May 1, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login not working if alg field is missing in jwks_uri response
1 participant