New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pom.xml - update cloudbees-folder version to 6.6 #50
Commits on Jun 16, 2017
Commits on Jun 17, 2017
-
Merge pull request #144 from gabemontero/handle-build-delete
cancel jenkins runs when corresponding openshift builds are deleted
Commits on Jun 21, 2017
Commits on Jun 26, 2017
-
Merge pull request #153 from gabemontero/fix-pom-3
fix travis/jenkinsci complaints about java 1.8; throttle findbugs
Commits on Jun 30, 2017
Commits on Jul 21, 2017
-
-
Merge pull request #154 from gabemontero/fix-pr-tester-readme
Merged by openshift-bot
OpenShift Bot committedJul 21, 2017
Commits on Jul 27, 2017
-
override user-agent to distinguish sync-plugin in openshift master lo…
…gs; close cfgmap/is watches on sync plugin disable
-
Merge pull request #156 from gabemontero/realign
Merged by openshift-bot
OpenShift Bot committedJul 27, 2017
Commits on Jul 31, 2017
-
-
Merge pull request #157 from gabemontero/nicer-build-polling
throttle jenkins status to openshift build updates
-
Commits on Aug 3, 2017
-
Merge pull request #149 from gabemontero/auto-reg-is-ist-image-with-c…
…fgmap-podtmpl auto convert cfgmap podtemplate image if IS/IST ref with no registry
-
-
-
Merge pull request #158 from gabemontero/tweak-user-agent
tweak user agent setting to include plugin version
-
Merge pull request #159 from gabemontero/rename-token-credential
rename token credential to distinguish from other plugins
Commits on Aug 7, 2017
Commits on Aug 9, 2017
-
-
Merge pull request #161 from gabemontero/fix-blueocean-url
adjust reflection for blueocean url (changed their impls)
Commits on Aug 16, 2017
-
Keep existing Causes when pipeline build is manually triggered
- Some plugins that provide triggering may rely on a Cause that they added to perform additional steps at a later time in the build. That Cause needs to be kept. - An example of such a plugin is ghprb or Github Pull Request Builder. It looks at the Cause to extract information about the PR that triggered the build. - Also included in this commit, is support for determining the Jenkins url in the event that someone created a Jenkins service that is not called 'jenkins'. Without this, the 'View Logs' from an Openshift pipeline build would not have the correct url.
-
Merge pull request #164 from scoheb/o-fix-missing-causes
Keep existing Causes when pipeline build is manually triggered
Commits on Aug 21, 2017
Commits on Aug 22, 2017
-
-
Merge pull request #162 from gabemontero/bump-fabric
bump fabric, which also bumps okhttp
-
Merge pull request #165 from gabemontero/cfg-map-override-existing-sl…
…aves more consistently overwrite k8s template list, vs. add to list
Commits on Aug 23, 2017
-
-
Merge pull request #166 from gabemontero/format
apply universal eclipse form, space instead of tabs
Commits on Aug 25, 2017
Commits on Aug 30, 2017
-
-
Merge pull request #167 from bparees/maintainers
Merged by openshift-bot
OpenShift Bot committedAug 30, 2017
Commits on Sep 5, 2017
Commits on Sep 6, 2017
-
Merge pull request #169 from gabemontero/bump-fabric
Merged by openshift-bot
OpenShift Bot committedSep 6, 2017
Commits on Sep 10, 2017
Commits on Sep 11, 2017
-
Merge pull request #170 from gabemontero/npe-when-disabled
Merged by openshift-bot
OpenShift Bot committedSep 11, 2017
Commits on Sep 20, 2017
-
implement a build cache for build watch events that come before bc ev…
…ents for bc creation, then trigger build job when bc arrives
-
Merge pull request #171 from gabemontero/build-watch-cache
Merged by openshift-bot
OpenShift Bot committedSep 20, 2017
Commits on Sep 25, 2017
-
-
Merge pull request #174 from gabemontero/work-around-3.6-api-issue
Merged by openshift-bot
OpenShift Bot committedSep 25, 2017
Commits on Oct 5, 2017
-
Merge pull request #177 from gabemontero/fix-linkage-prow-integ
Merged by openshift-bot
OpenShift Bot committedOct 5, 2017
Commits on Oct 12, 2017
-
* 1. lets allow jobs to be syncd to new BCs if the job name matches a configured jobNamePattern 2. handle creating a new BC if BuildConfigProjectProperty is null 3. lets handle creating new BCs better; updating the UUID if its not preset on the property and only inserting/updating valid pipeline jobs with a jenkinsfile/path 4. add test dependencies for running the github org plugin 5. lets handle ItemGroup to find nested WorkflowJobs inside multi-branch jobs 6. if this is a multi branch workflow project then by default we only look for files that match Jenkinsfile so no need to set optional BC value 7. lets use safe names for the generated BuildConfig names 8. fixes creating BuildConfigs from multibranch jobs and ensuring that the generated BuildConfigs don't generate new Jobs via the BuildWatcher 9.lets try avoid the github organisation prefix and the master branch suffix by default for the generated BuildConfig names 10. refactor to use a constants class for annotations; fixed up name versus fullPath logic and allow BCs to be annotated to avoid creating a linked jenkins job 11. lets support using a folder for each namespace so that BuildConfigs created via openshift look nice and clean inside Jenkins 12. address findbug issues 13. ets add support for ${FOO} environment variable expressions for the namespace to watch 14. fixes openshift#131 to support the syncing of Secrets -> Jenkins Credentials 15. lets annotate the Build with pending input JSON so consoles can do the Proceed/Abort stuff if they want 16. added a Build annotation for the namespace jenkins is running inside * Resolving code reviews from @gabemontero 1. changed getOpenShiftClient() -> getAuthenticatedOpenShiftClient were suggested 2. changed the annotation name from DISABLE_SYNC_CREATE_ON -> DISABLE_SYNC_CREATE 3. Added a comment for the need of getPendingActionsJson method * Resolve conflicts * fixed reviews from @bparees * formatting in eclipse style * 1.fixing review from @bparees 2.missing eclipse style formatting
-
Merge pull request #178 from gabemontero/fix-npe
Merged by openshift-bot
OpenShift Bot committedOct 12, 2017
Commits on Oct 19, 2017
-
Merge pull request #181 from gabemontero/cd-team-npes
Merged by openshift-bot
OpenShift Bot committedOct 19, 2017
Commits on Oct 20, 2017
-
Merge pull request #182 from gabemontero/find-overlooked-builds
Merged by openshift-bot
OpenShift Bot committedOct 20, 2017 -
-
-
Merge pull request #183 from gabemontero/more-corrupt-bld-protect
Merged by openshift-bot
OpenShift Bot committedOct 20, 2017
Commits on Oct 25, 2017
Commits on Nov 20, 2017
-
-
Merge pull request #185 from gabemontero/json-for-declar
Merged by openshift-bot
OpenShift Bot committedNov 20, 2017 -
Merge pull request #184 from gabemontero/jira-42276
Merged by openshift-bot
OpenShift Bot committedNov 20, 2017
Commits on Dec 5, 2017
Commits on Dec 6, 2017
-
Merge pull request #188 from gabemontero/is-watch-auto-pull
Merged by openshift-bot
OpenShift Bot committedDec 6, 2017 -
Commits on Dec 14, 2017
-
post rebase cleanup; get existing secret watch functionality to work
add delete processing for secret/credentials sync (incorporate bc/srcSecret/credential sync as well) fix up some discovered holes in bc src secret mgmt
-
Merge pull request #189 from gabemontero/secrets-polish
Merged by openshift-bot
OpenShift Bot committedDec 14, 2017 -
Commits on Jan 17, 2018
-
-
Merge pull request #192 from gabemontero/protect-blueocean-call
Merged by openshift-bot
OpenShift Bot committedJan 17, 2018
Commits on Jan 22, 2018
Commits on Jan 24, 2018
-
Merge pull request #193 from gabemontero/bump-blueocean-fallout
Merged by openshift-bot
OpenShift Bot committedJan 24, 2018 -
Commits on Jan 26, 2018
-
preserve stage order when accounting for skipped declarative pipeline…
… steps in build json annotation
-
Merge pull request #195 from gabemontero/fix-stage-order
Merged by openshift-bot
OpenShift Bot committedJan 26, 2018 -
Commits on Jan 30, 2018
-
Merge pull request #196 from gabemontero/confirm-params-added
Merged by openshift-bot
OpenShift Bot committedJan 30, 2018 -
Commits on Feb 14, 2018
-
leverage jenkins config, then jenkins namespace, before build namespa…
…ce, for root urls; format
-
Merge pull request #198 from gabemontero/fix-jenkins-namespace-for-ro…
…ot-url Merged by openshift-bot
OpenShift Bot committedFeb 14, 2018 -
Commits on Feb 16, 2018
-
-
Merge pull request #204 from gabemontero/more-polling-tuning
Merged by openshift-bot
OpenShift Bot committedFeb 16, 2018
Commits on Feb 19, 2018
Commits on Feb 23, 2018
-
Merge pull request #208 from gabemontero/fix-npe-creds
Merged by openshift-bot
OpenShift Bot committedFeb 23, 2018 -
Commits on Feb 26, 2018
-
-
Merge pull request #210 from gabemontero/fix-reject-ssh-secret-no-use…
…rname Merged by openshift-bot
OpenShift Bot committedFeb 26, 2018 -
Commits on Feb 27, 2018
-
-
-
-
Merge pull request #211 from gabemontero/fix-bc-delete
Merged by openshift-bot
OpenShift Bot committedFeb 27, 2018 -
Commits on Mar 7, 2018
-
Bootstrap an OWNERS file (#213)
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Commits on Mar 9, 2018
-
Delete job run when build is deleted from OpenShift
https://trello.com/c/FxtSMIUm/1447-5-removing-a-build-object-should-remove-the-corresponding-jenkins-job-jenkinsintegration - Updates the openshift-client version from 2.3.1 to 3.0.3 - Jenkins will no longer remove the successfulBuildsHistoryLimit and failedBuildsHistoryLimit from the BuildConfig - Jenkins job runs will be deleted if/when the associated build is deleted from OpenShift Refactoring deleteRun to take a run instead of a job and a build
Commits on Mar 10, 2018
-
Merge pull request #199 from coreydaley/trello_1447_remove_build_obje…
…ct_should_remove_job_run Delete Jenkins job run when build is deleted from OpenShift
Commits on Mar 11, 2018
Commits on Mar 19, 2018
-
more logging around closed watches; lazy reconnect on closed watch (#…
…214) * more logging around closed watches * set up for rewatch on next relist * add watch closure logging, passive watch reconnect, refactor watch callback to per namespace granularity
-
Commits on Mar 27, 2018
-
Flush the build HashSet directly without clone it.
originally in order to flush the build HashSet, the haset was cloned in order to handle the right builds. this clone theoretically holds references that can't be collected by the GC. using the build HashSet directly potentially can save some memory. by testing this PR, I found nicer heap memory, and about ~20mb less the usall.
Eldad Marciano committedMar 27, 2018
Commits on Apr 3, 2018
-
Merge pull request #215 from mrsiano/performance
Flush the build HashSet directly without clone it.
Commits on Apr 4, 2018
-
-
-
* configurable list intervals * fix watcher/lister leak on config change
Commits on Apr 6, 2018
Commits on Apr 9, 2018
-
Merge pull request #221 from gabemontero/concur-mod-excep-list-cfg
switch watcher map to Concurrent, clear out after loop to close vs. i…
Commits on Apr 10, 2018
-
Add sync of Openshift opaque secrets to Jenkins file credentials
- Opaque secrets can now be synced provided they have a filename attribute oc create secret generic mysecretfile --from-file=filename=mysecret.txt oc label secret mysecretfile credential.sync.jenkins.openshift.io=true // In Jenkinsfile // the credential will be created by the plugin with the name '<namespace>-<secretname>' withCredentials([file(credentialsId: 'namespace-mysecretfile', variable: 'MYFILE')]) { sh ''' #!/bin/bash cp ${MYFILE} newsecretfile.txt ''' }
Commits on Apr 11, 2018
-
Merge pull request #222 from scoheb/add-file-credentials-sync-2
Add sync of Openshift opaque secrets to Jenkins file credentials
Commits on Apr 12, 2018
-
Reconcile running on non-openshift pipeline builds
non-openshift jobs should not be processed by the reconciliation logic Fixes openshift/jenkins#567
Commits on Apr 13, 2018
-
Merge pull request #223 from coreydaley/github_567_reconcile_running_…
…on_non_openshift_pipelines Reconcile running on non-openshift pipeline builds
-
Commits on Apr 15, 2018
-
Merge pull request #224 from coreydaley/github_1565894_delete_job_run…
…_delayed Jenkins job run delete delayed
Commits on Apr 16, 2018
-
buildConfigPropertyForJob does not loop through all namespaces
The PipelineJobListener takes jobs created in Jenkins that match a specific jobNamePattern and created buildConfigs for them in OpenShift. It also updates the buildConfig in OpenShift if the job is updated in Jenkins. It does not seem to do any syncing from OpenShift -> Jenkins. PipelineJobListener.buildConfigPropertyForJob was basically just using the first defined namespace from the GlobalPluginConfiguration.namespaces property by just looping over the first value, which was confusing. I have just updated the code to be easier to read and less confusion. The other way to accomplish this would be to use client.getNamespace() to use the users default namespace which also seems like a valid option. Though this way at least provides the user a way to configure which namespace the buildConfig should be created in by chaning the order of the namespaces in the plugin configuration. Fixes #200
-
Merge pull request #225 from coreydaley/github_200_buildConfigProject…
…ForJob_does_not_loop_all_namespaces buildConfigPropertyForJob does not loop through all namespaces
Commits on Apr 19, 2018
Commits on Apr 20, 2018
Commits on Apr 22, 2018
-
Merge pull request #229 from coreydaley/github_200_buildConfigProject…
…ForJob_does_not_loop_all_namespaces_null_fix Fixing namespace could be null
Commits on Apr 23, 2018
Commits on Apr 24, 2018
Commits on Apr 25, 2018
-
Merge pull request #231 from jmcshane/master
Adding foldersEnabled field to global configuration
Commits on Apr 26, 2018
-
unblocking - use java.concurrent without blocking. (#234)
This PR remove blocking (synchronized), in order to reduce blocking time and blocked threads. and use java.util.concurrent as much as possible.
Commits on Apr 30, 2018
-
-
Merge pull request #235 from gabemontero/do-not-upd-if-paused
do not update build repeatedly if paused for update
Commits on May 1, 2018
-
-
Merge pull request #237 from mikenairn/add_certificate_credentials
Add support for syncing certificate type credentials.
-
Commits on May 24, 2018
-
-
Fixed the issue of duplicate pipeline (#239)
* Fixed the issue of duplicate pipeline Right now, when the buildconfig name is different then git repo name then sync plugin is not able to find buildconfig by repo name while syncing back to openshift after creating a buildconfig with strategy JenkinsPipeline, and create a new buildconfig repo name, To fix this issue, added a label of gitRepository name so it will first try to find the BuildConfig with name of jenkins job, if that is not present that is our case then it will also try to find the buildconfig having label with the name of jenkins job and then if it is not present will create a new BuildConfig #27 Declared constant variable for label key Removed NPE and added comments in the code to always know the context behind this * Updated wrong logging in #28 PR
Commits on May 31, 2018
Commits on Jun 13, 2018
-
Merge pull request #240 from gabemontero/cred-username-decode
decode username on ssh user credential
Commits on Jun 15, 2018
Commits on Jul 10, 2018
Commits on Jul 11, 2018
-
add support for secret text credentials
ryan-kenney committedJul 11, 2018 -
add secret text info to warning log
ryan-kenney committedJul 11, 2018 -
use Secret.fromString to parse the value
ryan-kenney committedJul 11, 2018 -
Merge pull request #244 from rkenney525/feature/secret-text-support
Add support for Secret Text (token) style Credentials
Commits on Jul 18, 2018
-
Merge pull request #247 from gabemontero/is-ist-poll-compare
on IS events/poll, compare image as well as name as part of existence…
Commits on Jul 26, 2018
Commits on Aug 10, 2018
-
Fix env vars from JenkinsPipelineBuildStrategy could be null values
When start a JenkinsPipelineBuildStrategy with `oc start-build`, if there is an environment variable with an empty string value, the corresponding parameter will be set to null value. This could lead to exceptions. This PR fixes this issue by replacing null values with empty strings when passing environment variables from JenkinsPipelineBuildStrategy to ParametersAction.
-
Merge pull request #250 from vfreex/fix-null-parameter
Fix env vars from JenkinsPipelineBuildStrategy could be null values
Commits on Aug 13, 2018
Commits on Aug 14, 2018
Commits on Aug 24, 2018
-
Fix duplicate job run parameters
Triggering a job run from Jenkins UI or triggers defined in the job could cause duplicate parameters. This is caused by missing checks between the build strategy parameters with user specified ones. Using LinkedHashMap instread of ArrayList for parameters can solve this issue.
Commits on Aug 27, 2018
Commits on Aug 29, 2018
-
Additional fix of the null parameter issue
Following up #250 and [Bug 1614695](https://bugzilla.redhat.com/show_bug.cgi?id=1614695), the null string value should also be replaced with empty string when creating a Jenkins job, otherwise a job run triggered by timer or pollSCM triggers will also fail with NullPointerException.
-
Merge pull request #256 from vfreex/fix-null-parameter-2
Additional fix of the null parameter issue
Commits on Aug 30, 2018
-
-
Merge pull request #258 from gabemontero/non-type-secrets
adjust secret/credential mapping to account for optional secret type …
Commits on Sep 10, 2018
Commits on Sep 17, 2018
-
Signed-off-by: Major Hayden <major@redhat.com>
-
Merge pull request #261 from major/small-readme-fix
Fix spelling error in README
Commits on Sep 25, 2018
-
Merge pull request #263 from gabemontero/more-opaque-secret-fix
add isBlank check for arbitrary secret a la the other opaque types
Commits on Oct 1, 2018
-
-
Merge pull request #264 from svenstaro/patch-1
Fix spelling mistake
Commits on Nov 13, 2018
-
add retry on retrieval of job for param verification, full abort on b…
…uild if job not found switch PR test img to 3.11 until we move off of aos-cd-jobs
Commits on Nov 14, 2018
-
Merge pull request #273 from gabemontero/wait-on-job
add retry on retrieval of job for param verification, full abort on b…
Commits on Dec 6, 2018
-
pom.xml - update cloudbees-folder version to 6.6
the current cloudbees-folder version, 5.18, does not work when you have a newer version of the folder plugin, such as with CloudBees 2.138 which has version 6.6 installed.