Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Jenkins Core to 2.401 + Add support for OutputStreamTaskListener #781

Merged
merged 6 commits into from
Dec 28, 2023

Conversation

cyrille-leclerc
Copy link
Contributor

@cyrille-leclerc cyrille-leclerc commented Dec 19, 2023

Bump Jenkins Core to 2.401 + Add support for OutputStreamTaskListener

Fix for:

Build will pass after merging:

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
@kuisathaverat
Copy link
Contributor

kuisathaverat commented Dec 22, 2023

related to changes in the workflow plugin jenkinsci/workflow-api-plugin#294 and jenkinsci/workflow-durable-task-step-plugin#323

@cyrille-leclerc
Copy link
Contributor Author

@kuisathaverat it's ready for review. I can't say we improve the readability of the code. the nuances between BuildListener and TaskListener didn't help us 😄

@kuisathaverat
Copy link
Contributor

I will take a look next week, overall LGTM, but I want to make a manual test of everything.

@kuisathaverat kuisathaverat merged commit 33995ad into master Dec 28, 2023
14 checks passed
@kuisathaverat kuisathaverat deleted the bump-jenkins-core-2.401 branch December 28, 2023 12:17
@kuisathaverat kuisathaverat added the bug Something isn't working label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants