First version of the GrafanaLogsBackendWithJenkinsVisualization #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
…quest-parameters` Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
# Conflicts: # pom.xml # src/main/java/io/jenkins/plugins/opentelemetry/OpenTelemetrySdkProvider.java
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...enkins/plugins/opentelemetry/backend/grafana/GrafanaLogsBackendWithJenkinsVisualization.java
Fixed
Show fixed
Hide fixed
| @Extension(ordinal = 50) | ||
| public static class DescriptorImpl extends GrafanaLogsBackend.DescriptorImpl { | ||
|
|
||
| public FormValidation doCheckLokiUrl(@QueryParameter("lokiUrl") String url) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation Warning
...enkins/plugins/opentelemetry/backend/grafana/GrafanaLogsBackendWithJenkinsVisualization.java
Fixed
Show fixed
Hide fixed
| @Extension(ordinal = 50) | ||
| public static class DescriptorImpl extends GrafanaLogsBackend.DescriptorImpl { | ||
|
|
||
| public FormValidation doCheckLokiUrl(@QueryParameter("lokiUrl") String url) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
kuisathaverat
previously approved these changes
Jun 21, 2024
|
The merge will trigger a release, so it is better to merge on Monday. |
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
|
A last review please @kuisathaverat 👼 a few security improvements |
kuisathaverat
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version of the GrafanaLogsBackendWithJenkinsVisualization
Testing done
Submitter checklist