Fix for p4 environment variables being wrong in parallel pipeline syncs #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion created by this perforce scm and use it for creating environment variables. This prevents perforce scm from setting the environment variables based on another perforce scm's tag action.
|
I'd like to add a test to verify the issue is indeed fixed. Will try to get some time to do that. Though I think the code makes more sense this way regardless. |
|
Parallel and concurrent execution are hard areas to test especially if timing is involved. Not sure if this helps, but some build calls are blocking e.g. job.scheduleBuild2(0).get(); There are other calls like jenkins.waitUntilNoActivity(); that can catch you out as they may return early if the build is still queued and not started. |
|
Thank you for the fix - I have merged you changes and added a test case in commit 787682f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-52806 - Store the tagAction created by this perforce scm and use it for creating environment variables. This prevents this perforce scm from setting the environment variables based on another perforce scm's tag action.