Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPM: Add settings for HTTP/2 in sysconfig #115

Merged
merged 4 commits into from Aug 27, 2019
Merged

RPM: Add settings for HTTP/2 in sysconfig #115

merged 4 commits into from Aug 27, 2019

Conversation

tn-osimis
Copy link
Contributor

No description provided.

@tn-osimis
Copy link
Contributor Author

Warning: Untested, just a suggestion.

oleg-nenashev
oleg-nenashev approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CC @olamy since HTTP2 settings come from Winstone

olamy
olamy approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but http2 need more setup https://github.com/jenkinsci/winstone/#http2-support

@tn-osimis
Copy link
Contributor Author

@olamy Indeed. What do you think about this? I believe something like it would suffice for Java 9+.

@olamy
Copy link
Member

olamy commented May 3, 2019 •
edited

@tn-osimis as I said in doc
With Java9+ you do not need anymore to include the ALPN jar in the bootclasspath but only the jar jetty-alpn-java-server in the extraLibFolder :)
were you able to use it in a different way with 9+?

@tn-osimis
Merge pull request #1 from tn-osimis/rpm-http2-docref
173eadb 
Add extra libraries directory setting and HTTP/2 documentation references
@tn-osimis
Copy link
Contributor Author

@olamy Oh not at all, I was indeed following this documentation. Just wanted to make sure everyone was fine with this being a Java 9+ thing only since I didn't include a setting for the -Xbootclasspath/p option (and fine with the general approach indeed; I guess this could be smarter about detecting versions and dependencies automatically but I decided against it).

So, I pulled the change in this PR accordingly. I'll try to build and test ASAP but if you preempt me I reckon this could be ready for merge.

olamy
olamy approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleg-nenashev oleg-nenashev changed the title rpm: Add settings for HTTP/2 in sysconfig RPM: Add settings for HTTP/2 in sysconfig Aug 27, 2019
@oleg-nenashev oleg-nenashev merged commit c769106 into jenkinsci:master Aug 27, 2019
olblak pushed a commit to olblak/packaging that referenced this pull request Nov 22, 2019
@tn-osimis @olblak
rpm: Add setting for specifying extra libraries directory
97934a2 
Context: jenkinsci#115 (review)
olblak pushed a commit to olblak/packaging that referenced this pull request Nov 22, 2019
@tn-osimis @olblak
rpm: Warn about HTTP/2 extra configuration requirements
8511b59 
Context: jenkinsci#115 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tn-osimis @olamy @oleg-nenashev