Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of jenkinsci/jenkins#6356 there is no longer any need for
--add-opens
on Java 17, but there is still a problem with the version check in this repository which causes a hard failure on anything other than Java 8 and Java 11. I considered removing this entirely, as it seems to be a bit heavy-handed, but then I decided that it is a useful guardrail to prevent users from accidentally running Jenkins in an unsupported configuration. So instead I am just skipping the Java version check when the--enable-future-java
Jenkins option is provided, which is needed to enable Java 17 preview support anyway.Testing done
Functional testing: started Jenkins successfully with Java 17 and this
systemd
configuration (with jenkinsci/jenkins#6356):Regression testing: started Jenkins successfully with Java 11 and this
systemd
configuration:Fixes #217