Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Java version checks #429

Merged
merged 1 commit into from Aug 24, 2023
Merged

Conversation

basil
Copy link
Member

@basil basil commented Aug 24, 2023

Alternative to #428. Redundant now that core has Java version checking which (though itself implemented in Java) is compiled down to very low (currently Java 8) bytecode so that it can successfully print an error message even when the user is running a very old version of Java.

Testing done

git grep -i java.version did not turn up any results.

@basil basil added the removed label Aug 24, 2023
@basil basil requested a review from a team as a code owner August 24, 2023 16:41
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit 34f53af into jenkinsci:master Aug 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants