Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard location for spotbugs exclusion file #304

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

MarkEWaite
Copy link
Contributor

Use standard location for spotbugs exclusion file

Parent pom 4.50 defines a standard location for the spotbugs exclusions file. When we use the standard location, it simplifies the pom file and makes it easier for developers to move from one plugin to another.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes

Parent pom 4.50 defines a standard location for the spotbugs exclusions
file.  When we use the standard location, it simplifies the pom file
and makes it easier for developers to move from one plugin to another.
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍
Thanks.

@MarkEWaite MarkEWaite enabled auto-merge (rebase) November 9, 2022 13:53
@MarkEWaite MarkEWaite merged commit b289d1f into jenkinsci:master Nov 9, 2022
@MarkEWaite MarkEWaite deleted the move-spotbugs-file branch August 13, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants