Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Jenkins 2.387.3 or newer #338

Merged
merged 6 commits into from
Jun 18, 2023

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Jun 18, 2023

Require Jenkins 2.387.3 or newer

Update plugin to require Jenkins 2.387.3 or newer. Remove unused entries from pom.xml. Remove test that depends on a service that was decommissioned in 2016.

  • Add deprecated annotation to deprecated method
  • Remove unused entries from pom file
  • Require Jenkins 2.387.3 or newer
  • Remove more unused dependency entries
  • Remove test that relies on dead service

Testing done

Automated tests run successfully on Linux with Java 11.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@MarkEWaite MarkEWaite enabled auto-merge (squash) June 18, 2023 18:01
Tests pass on my JDK 17 environment
@MarkEWaite MarkEWaite disabled auto-merge June 18, 2023 21:10
@MarkEWaite MarkEWaite merged commit f4ca897 into jenkinsci:master Jun 18, 2023
13 checks passed
@MarkEWaite MarkEWaite deleted the simplify-pom-file branch June 18, 2023 21:11
@basil
Copy link
Member

basil commented Jun 28, 2023

BOM test passed in jenkinsci/bom#2222

Would be great to get a release of this so that we can add parameterized-trigger to BOM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants