Option to follow symbolic links in Full backup #13
Conversation
|
@oleg-nenashev Can you please review this PR / add someone who can help with the review |
|
@emanuelez @johnou Can you please review this PR ? TIA 🙏 |
|
I stepped down as a maintainer long long ago. I have no bandwidth for this plugin anymore due to other roles in the Jenkins project, and anyone interested in the plugin is welcome to adopt it. Sorry for such response. https://jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/ |
|
Thanks @oleg-nenashev for your reply! I'll reach out in the mailing list for adopting the plugin. |
src/main/java/org/jenkinsci/plugins/periodicbackup/FullBackup.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/periodicbackup/FullBackup.java
Outdated
Show resolved
Hide resolved
|
Thanks much @johnou for reviewing! I addressed your comments and I've tested the backward compatibility with old config and it is working fine. I don't see any issues. |
|
Thanks @maselvaraj! |
|
@johnou Hi. Do you take ownership of the plugin back? I am reworking the adoption process, and I wonder whether I should mark it for adoption in GitHub |
|
@oleg-nenashev sure, it's pretty low traffic anyway. My sonatype credentials should still be valid, right? |
|
@johnou Would you be able to cut a release for the plugin 🙇 ? |
|
@maselvaraj currently waiting for permission so I can push releases again. |
|
@maselvaraj released. |
|
Awesome ! Thank you @johnou 🙇 ! |
|
Thanks for the contribution. |
Adds a checkbox that enables "follow symlinks" in "Full backup" which fixes the issue emanuelez#1
If Jenkins home is a symlink to another directory, then backup would fail since code ignores symlinks. This PR adds an option that a user can select to follow symlinks. If this check box is enabled, then full backup will work even if Jenkins home is a symlink.
Related PR that disabled symlink : #9 . I think it's better to give the choice to the user to follow symlinks or not. While the default is still not to follow symlinks.