-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-65324] added a missing online help #50
Conversation
Hi @MarkEWaite and @StackScribe, Here is my pull request for the missing pipeline help task. I am looking forward to your feedback. Thanks |
@basil do you have permission to merge this pull request and #49 ? The SheCodeAfrica Contributhon is working during April to improve the Pipeline step descriptions, Pipeline argument descriptions, and Pipeline examples. We'd love to have fast review of their work |
I do not; as far as I can tell, @dwnusbaum is the primary maintainer of the Pipeline plugins who merges PRs. Let me know if there's any way I can help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the pattern of help documentation is to explain what the setting does, and then to state the default. Otherwise, this looks fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to what @kwhetstone said. Also please add line break at the end of the file
@kwhetstone and @oleg-nenashev, thank you for the feedback. I have made changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Hi @MarkEWaite @kwhetstone, I have worked on your reviews. If there are no other improvements you want me to make, it would be amazing if you accept this PR and merge it. Thank you! |
I added a missing online help for the wait argument
https://issues.jenkins.io/browse/JENKINS-65324