Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-65338]- Add snippet generator hint to build step help #51

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

Onyimatics
Copy link
Contributor

@Onyimatics Onyimatics commented Apr 10, 2021

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!

  • Ensure that the pull request title represents the desired changelog entry

  • Please describe what you did

  • Added snippet generator hint to build step help

  • Link to relevant issues in GitHub or Jira

  • JENKINS-65338

Hello @MarkEWaite @oleg-nenashev @kwhetstone @StackScribe, please kindly review.

Triggers a new build for a given job.
</p>
<p>
Use the <a href="https://www.jenkins.io/redirect/pipeline-snippet-generator">Pipeline Snippet Generator</a> to generate a sample pipeline script for the build step.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to link it to the snippet generator itself instead of its docs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work to link to the snippet generator? This page is included in both the online help inside Jenkins and the Pipeline steps reference. I assumed that a link to the snippet generator inside Jenkins would result in broken link complaints from readers of the Pipeline steps reference.

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Apr 10, 2021 via email

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections w.r.t merging as is. Too late to address the comment about the Snippet generator. For the future, it would be nice to timely get a response from the PR author

…s/build/BuildTriggerStep/help.html

Co-authored-by: Ramon Leon <manuelramonleonjimenez@gmail.com>
@bitwiseman bitwiseman merged commit bbaba59 into jenkinsci:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants