Add commitId to Review object

Allows identifying outdated reviews by comparing review commit ID with PR head revision.
jenkinsci · May 7, 2018 · 7fa0d37 · 7fa0d37
1 parent a84d222
commit 7fa0d37
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -360,6 +360,7 @@ Name | Type | Setter | Description
 id | `long` | false
 user | `String` | false
 body | `String` | false
+commitId | `String` | false
 state | `String` | One of APPROVED, PENDING, CHANGES_REQUESTED, DISMISSED, COMMENTED
 
 ### Methods

diff --git a/src/main/java/org/jenkinsci/plugins/pipeline/github/ReviewGroovyObject.java b/src/main/java/org/jenkinsci/plugins/pipeline/github/ReviewGroovyObject.java
@@ -26,6 +26,11 @@ public String getBody() {
         return review.getBody();
     }
 
+    @Whitelisted
+    public String getCommitId() {
+        return review.getCommitId();
+    }
+
     @Whitelisted
     public long getId() {
         return review.getId();

diff --git a/src/main/java/org/jenkinsci/plugins/pipeline/github/client/Review.java b/src/main/java/org/jenkinsci/plugins/pipeline/github/client/Review.java
@@ -23,6 +23,7 @@ public class Review implements Serializable {
         .collect(Collectors.collectingAndThen(Collectors.toSet(), Collections::unmodifiableSet));
 
     private String body;
+    private String commitId;
     private long id;
     private User user;
     private String state;
@@ -36,6 +37,15 @@ public Review setBody(final String body) {
         return this;
     }
 
+    public String getCommitId() {
+        return commitId;
+    }
+
+    public Review setCommitId(final String commitId) {
+        this.commitId = commitId;
+        return this;
+    }
+
     public long getId() {
         return id;
     }