Small improvements to branch labels #387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status Quo
Give branch labels an outline
Without an outline the contrast between the background and the label is much too low,
and IMO it looks much cleaner with an outline.
Outline instead of a border, because outlines don't take up space in the element.
Reduce branch label padding
With only 70 pixels allocated for the label, using 14 pixels for padding is a bit much.
Increase branch label height
Previously characters that went below the baseline were clipped.
Remove explicit use of the any type
Type system changes only.
Testing done
Tested in darkmode.
![screenshot-2024-04-21_19-27-50](https://private-user-images.githubusercontent.com/50487108/324266566-30c056fc-5db2-4723-921a-e5f8edc2d49e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxNDAxNjAsIm5iZiI6MTcxOTEzOTg2MCwicGF0aCI6Ii81MDQ4NzEwOC8zMjQyNjY1NjYtMzBjMDU2ZmMtNWRiMi00NzIzLTkyMWEtZTVmOGVkYzJkNDllLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIzVDEwNTEwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFkYWRkOGQzNjIwNDUyOGFmM2VhNDM5OWQwMTU4ZGU3ODk3ZTAxYWI3NjM2YTFlY2MzMjdkMmNmOGU2ODVkNTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.k8-SpKEj9ys-AtrrZZ0f2IVyuZlL_HKUqgjqoR43U2Y)
Tested with "Show pipeline graph on build page" (
![screenshot-2024-04-21_19-32-28](https://private-user-images.githubusercontent.com/50487108/324266825-48eb6f23-4965-48db-bbd2-f6f5abb0629e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxNDAxNjAsIm5iZiI6MTcxOTEzOTg2MCwicGF0aCI6Ii81MDQ4NzEwOC8zMjQyNjY4MjUtNDhlYjZmMjMtNDk2NS00OGRiLWJiZDItZjZmNWFiYjA2MjllLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIzVDEwNTEwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI0YWUwZTkzYjljYzM3YzYyMjVmM2Q3OWMxYjJjNGMxOGFiNTc2NTA4MTM2MDllY2VmMWQ3M2Q3NDIyNGVkYWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.yj2XQ0tTDalpFZ0jS4WuQBXrxFEIC43sCHfjjDmgiwc)
/jenkins/manage/appearance/
) on.Submitter checklist