Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to branch labels #387

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Conversation

DominikRusso
Copy link
Contributor

Status Quo

screenshot-2024-04-21_19-20-10

Give branch labels an outline

Without an outline the contrast between the background and the label is much too low,
and IMO it looks much cleaner with an outline.

Outline instead of a border, because outlines don't take up space in the element.

screenshot-2024-04-21_19-21-49

Reduce branch label padding

With only 70 pixels allocated for the label, using 14 pixels for padding is a bit much.

screenshot-2024-04-21_19-23-04

Increase branch label height

Previously characters that went below the baseline were clipped.

screenshot-2024-04-21_19-25-15

Remove explicit use of the any type

Type system changes only.


Testing done

  • Tested in darkmode.
    screenshot-2024-04-21_19-27-50

  • Tested with "Show pipeline graph on build page" (/jenkins/manage/appearance/) on.
    screenshot-2024-04-21_19-32-28

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

since it has a max width of only 70px
to fit letters that go below the baseline

and derive margin-top from line-height
@DominikRusso DominikRusso requested a review from a team as a code owner April 21, 2024 17:40
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@timja timja added the enhancement New feature or request label Apr 22, 2024
@timja timja merged commit 92d72e3 into jenkinsci:main Apr 22, 2024
14 checks passed
@lemeurherve
Copy link
Member

Thanks @DominikRusso, looks much nicer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants