Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat publisher documentation #348

Merged
merged 1 commit into from Sep 9, 2021
Merged

Reformat publisher documentation #348

merged 1 commit into from Sep 9, 2021

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Jul 4, 2021

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • [n/a] Link to relevant pull requests, esp. upstream and downstream changes
  • [n/a] Ensure you have provided tests - that demonstrates feature works or fixes the issue

The goal is to avoid horizontal scrolling for better display in GitHub and plugin site (jenkins-infra/plugin-site#750)

This PR splits the big table with horizontal scrolling into a table and a definition list.

@zbynek zbynek requested a review from aheritier as a code owner July 4, 2021 11:23
@zbynek
Copy link
Contributor Author

zbynek commented Jul 14, 2021

@aheritier will you have time to check this?

@aheritier
Copy link
Member

I am back @zbynek
I will do it soon
Thanks a lot for this contribution, I agree with your fix. It's not readable today and we have to simplify this table like you did

Copy link
Member

@aheritier aheritier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @zbynek

sorry again for the delay

@aheritier aheritier merged commit a2338dd into jenkinsci:master Sep 9, 2021
@aheritier aheritier self-assigned this Sep 9, 2021
@zbynek zbynek deleted the patch-1 branch September 9, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants