JENKINS-59813 pipeline-maven JacocoPublisher handle excludes properly #764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution for JENKINS-59813
The jacoco report published by pipeline includes classes that should have been excluded.
If the pom declares "excludes" in the jacoco-maven-plugin configuration, then those patterns should be forwarded on to the JacocoPublisher so the generated report excludes those.
The proposed changes will look for any "excludes" xml elements in the jacocoPrepareAgentEvent elements and collect any patterns in there which are then passed through to the JacocoPublisher at the end.
Testing done
The JacocoReportPublisherTest was updated to exercise the impacted code path. Also manual testing of the locally built plugin solved my use case.
Submitter checklist