Export "newerBuild" so that BO REST can use it #7
Conversation
There was a problem hiding this comment.
Would rather export the build number as an int.
(In the original PR to create the step, IIRC I did suggest replacing newerBuild with a number. For whatever reason that did not happen, and it is tricky to replace the serialized field now, but I did not care so much because it was private anyway. This is becoming part of an API.)
Alternately, simply add @Exported to getNewerBuild. You can then pick out ?tree=…[newerBuild[number]] or whatever.
|
@jglick serialising the run would be bad for Blue Ocean as that object could be rather large and isn't in the format our client would understand, so I've opted to go with the I've also taken the liberty to clear up some messiness where the |
That is why you select only the desired fields, using for example |
|
@jglick any status update on this PR? After Jenkins World, I added some notes on the original PR that prompted this change: https://issues.jenkins-ci.org/browse/JENKINS-40871. Seems like once this gets in, we can start working on the UI side. I am not a front-end dev, but can certainly take a stab at it, as I think it would be super cool to have this "collapse" pipeline view on BO. If there is anything else I can help with to get this going, please let me know. |
Ask the submitter. My last recommendation was to instead add |
|
ah, you are right, I though the ball was on your court but is not. @i386 were you planning on following up on this PR? let me know if I can help from my end |
|
I am not working on this one anymore @adelcast - if you want to take over from here you can file a new PR :) |
@amuniz very quick one to make the
CancelledCauseserialize better via Blue Ocean REST API.Related to https://issues.jenkins-ci.org/browse/JENKINS-40871